Fix infinite retry if err is "no leader" #9133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the timeout calculation to the HasTimedOut method effectively removed it from the code path where either the args aren't implementing RPCInfo or if the error is "No cluster leader". This fix brings the timeout calculation before everything else and works as originally designed even if the args don't implement the RPCInfo interface.
|
this is a good fix but we found more issues in the retry code so to minimize churn I will close this and reopen a PR that addresses more timeout issues later. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the timeout calculation to the HasTimedOut method effectively
removed it from the code path where either the args aren't implementing
RPCInfo or if the error is "No cluster leader". This fix brings the
timeout calculation before everything else and works as originally
designed even if the args don't implement the RPCInfo interface.
PR that introduced the bug: #8921