e2e: fix destination of templates in VaultSecrets test #9146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$NOMAD_SECRETS_DIR` environment variable is rendered as `/secrets`, which prior to the recent security patch would unintentionally escape the file sandbox and get dropped in a directory named `/secrets` where the Nomad client binary was running. The `VaultSecrets` test was accidentally relying on this behavior and that causes the test to fail.
|
I've opened #9148 to work out the backwards incompatibility / UX. |
cgbaker
approved these changes
Oct 22, 2020
tgross
added a commit
that referenced
this pull request
Oct 23, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9144
The
$NOMAD_SECRETS_DIRenvironment variable is rendered as/secrets, whichif used as a
template.destinationprior to the recent security patch would unintentionallyescape the file sandbox and get dropped in a directory named
/secretswhere the Nomadclient binary was running. The
VaultSecretstest was accidentally relying on thisbehavior and that causes the test to fail.
This is an easy mistake to make, and makes me worry whether we have a lot of this
behavior "in the wild" and what we could do to improve the UX.
Addendum: in 0.12.5 it doesn't actually escape the file sandbox, but it fails the check in
0.12.6 as though it does. So there may be a bug in the patch 😦 (Going to spin that out to a new issue)