Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy executors are executors after all #9304

Merged
merged 2 commits into from
Nov 10, 2020
Merged

Legacy executors are executors after all #9304

merged 2 commits into from
Nov 10, 2020

Commits on Nov 10, 2020

  1. Legacy executors are executors after all 

    This fixes a bug where pre-0.9 executors fail to recover after an
upgrade.

The bug is that legacyExecutorWrappers didn't get updated with
ExecStreaming function, and thus failed to implement the Executor
function. Sadly, this meant that all recovery attempts fail, as the
runtime check in
https://github.com/hashicorp/nomad/blob/b312aacbc961dfd976b6a402d22d80b45176a962/drivers/shared/executor/utils.go#L103-L110
.
    Mahmood Ali committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    5847b93 View commit details
    Browse the repository at this point in the history

  2. update changelog 

    [ci skip]
    Mahmood Ali committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    dd7b6f0 View commit details
    Browse the repository at this point in the history