Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore nil devices in plugin fingerprint #9311

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Don't ignore nil devices in plugin fingerprint #9311

merged 1 commit into from
Nov 11, 2020

Commits on Nov 10, 2020

  1. Don't ignore nil devices in plugin fingerprint 

    Even if a plugin sends back an empty `[]*device.DeviceGroup`, it's transformed to `nil` during the RPC. Our custom device plugin is returning empty `FingerprintResponse.Devices` very often. Our temporary fix is to send a dummy `*DeviceGroup` if the slice is empty. This has the effect of never triggering the "first fingerprint" and therefore timing out after 50s.

In turn, this made our node exceed its hearbeat grace period when restarting it, revoking all vault tokens for its allocations, causing a restart of all our allocations because the token couldn't be renewed.

Removing the logic for `f.Devices == nil` does not appear to affect the functionality of the function.
    @jeromegn
    jeromegn committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    66ddf62 View commit details
    Browse the repository at this point in the history