Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: disallow volume mounts from host by default #9321

Merged
merged 1 commit into from
Nov 11, 2020
Merged

docker: disallow volume mounts from host by default #9321

merged 1 commit into from
Nov 11, 2020

Commits on Nov 11, 2020

  1. docker: disallow volume mounts from host by default 

    The default behavior for `docker.volumes.enabled` is intended to be `false`,
but the HCL schema defaults to `true` if the value is unset. Set the default
literal value to `true`.

Additionally, Docker driver mounts of type "volume" (but not "bind") are not
being properly sandboxed with that setting. Disable Docker mounts with type
"volume" entirely whenever the `docker.volumes.enabled` flag is set to
false. Note this is unrelated to the `volume_mount` feature, which is
constrained to preconfigured host volumes or whatever is mounted by a CSI
plugin.

This changeset includes updates to unit tests that should have been failing
under the documented behavior but were not.
    @tgross
    tgross committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    c7a1724 View commit details
    Browse the repository at this point in the history