Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi/ui: show Node Only for volumes when controllers aren't required #9416

Merged
merged 4 commits into from
Nov 25, 2020
Merged

csi/ui: show Node Only for volumes when controllers aren't required #9416

merged 4 commits into from
Nov 25, 2020

Commits on Nov 20, 2020

  1. csi/ui: show Node Only for volumes when controllers aren't required 

    Plugin health for controllers should show "Node Only" in the UI only when both
conditions are true: controllers are not required, and no controllers have
registered themselves (0 expected controllers). This accounts for "monolith"
plugins which might register as both controllers and nodes but not necessarily
have `ControllerRequired = true` because they don't implement the Controller
RPC endpoints we need (this requirement was added in #7844)

This changeset includes the following fixes:

* Update the Plugins tab of the UI so that monolith plugins don't show "Node
  Only" once they've registered.
* Add the missing "Node Only" logic to the Volumes tab of the UI.
    @tgross
    tgross committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c6004e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. fixup test

    @tgross
    tgross committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    7f5c2c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Michael Lange <dingoeatingfuzz@gmail.com>
    @tgross @DingoEatingFuzz
    tgross and DingoEatingFuzz committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    3774f7c View commit details
    Browse the repository at this point in the history

  2. fix test assertions

    @tgross
    tgross committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    1b5c81c View commit details
    Browse the repository at this point in the history