-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Do not merge - collecting performance patches for scale testing #9436
Draft
schmichael
wants to merge
6
commits into
main
Choose a base branch
from
scaletest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4192bd2 - Browse repository at this point
Copy the full SHA 4192bd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7342826 - Browse repository at this point
Copy the full SHA 7342826View commit details
Commits on Nov 24, 2020
-
deploymentwatcher: limit before snapshotting state
Prior to this change getAllocs work was split before and after the limiter. This moves all work after the limiter. **WIP** I'm unclear how to test this change or assert its benefits, so I'm leaving it as a draft for now unless others have ideas.
Configuration menu - View commit details
-
Copy full SHA for 40cb90c - Browse repository at this point
Copy the full SHA 40cb90cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59ca810 - Browse repository at this point
Copy the full SHA 59ca810View commit details -
client: always wait 200ms before sending updates
Always wait 200ms before calling the Node.UpdateAlloc RPC to send allocation updates to servers. Prior to this change we only reset the update ticker when an error was encountered. This meant the 200ms ticker was running while the RPC was being performed. If the RPC was slow due to network latency or server load and took >=200ms, the ticker would tick during the RPC. Then on the next loop only the select would randomly choose between the two viable cases: receive an update or fire the RPC again. If the RPC case won it would immediately loop again due to there being no updates to send. When the update chan receive is selected a single update is added to the slice. The odds are then 50/50 that the subsequent loop will send the single update instead of receiving any more updates. This could cause a couple of problems: 1. Since only a small number of updates are sent, the chan buffer may fill, applying backpressure, and slowing down other client operations. 2. The small number of updates sent may already be stale and not represent the current state of the allocation locally. A risk here is that it's hard to reason about how this will interact with the 50ms batches on servers when the servers under load. A further improvement would be to completely remove the alloc update chan and instead use a mutex to build a map of alloc updates. I wanted to test the lowest risk possible change on loaded servers first before making more drastic changes.
Configuration menu - View commit details
-
Copy full SHA for d7f9285 - Browse repository at this point
Copy the full SHA d7f9285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8acaa32 - Browse repository at this point
Copy the full SHA 8acaa32View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.