-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI: fix transaction handling in state store #9438
Merged
Merged
Commits on Nov 24, 2020
-
csi: failing test for concurrent plugin stop
CSI plugin counts can drift from the correct values if allocations for a CSI plugin stop concurrently, as with a job stop or a controller and node plugin on the same client. This test demonstrates the behavior.
Configuration menu - View commit details
-
Copy full SHA for 680b7c4 - Browse repository at this point
Copy the full SHA 680b7c4View commit details -
csi: snapshot in read-only CSI RPC endpoints for consistency
CSI volumes need to be "denormalized" with their plugins and (optionally) allocations. Read-only RPC endpoints should take a snapshot so that we can make multiple state store method calls with a consistent view.
Configuration menu - View commit details
-
Copy full SHA for ba4c0b3 - Browse repository at this point
Copy the full SHA ba4c0b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1dd685 - Browse repository at this point
Copy the full SHA b1dd685View commit details -
csi: remove nested read txn from plugin write txns
When making updates to CSI plugins, the state store methods that have open write transactions were querying the state store using the same methods used by the CSI RPC endpoint, but these method creates their own top-level read transactions. During concurrent plugin updates (as happens when a plugin job is stopped), this can cause write skew in the plugin counts. Refactor the CSIPlugin query methods to have an implementation method that accepts a transaction, which can be called with either a read txn or a write txn.
Configuration menu - View commit details
-
Copy full SHA for 22007f5 - Browse repository at this point
Copy the full SHA 22007f5View commit details -
Add missing nil checks and missing watch `Add` calls on some state store methods for CSI volumes
Configuration menu - View commit details
-
Copy full SHA for 962cd25 - Browse repository at this point
Copy the full SHA 962cd25View commit details -
csi: remove nested read txn from volume write txns
When making updates to CSI volumes, the state store methods that have open write transactions were querying the state store using the same methods used by the CSI RPC endpoint, but these method creates their own top-level read transactions. These have yet not been implicated in any bugs. Refactor the CSIVolume query methods to have an implementation method that accepts a transaction, which can be called with either a read txn or a write txn.
Configuration menu - View commit details
-
Copy full SHA for 8b88e59 - Browse repository at this point
Copy the full SHA 8b88e59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2188df3 - Browse repository at this point
Copy the full SHA 2188df3View commit details
Commits on Nov 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3b3bc87 - Browse repository at this point
Copy the full SHA 3b3bc87View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.