Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: kill signal API should include timeout context #9502

Merged
merged 1 commit into from
Dec 2, 2020
Merged

docker: kill signal API should include timeout context #9502

merged 1 commit into from
Dec 2, 2020

Commits on Dec 2, 2020

  1. docker: kill signal API should include timeout context 

    When the Docker driver kills as task, we send a request via the Docker API for
dockerd to fire the signal. We send that signal and then block for the
`kill_timeout` waiting for the container to exit. But if the Docker API
blocks, we will block indefinitely because we haven't configured the API call
with the same timeout.

This changeset is a minimal intervention to add the timeout to the Docker API
call _only_ when we have the `kill_timeout` set. Future work should examine
whether we should be threading contexts through other `go-dockerclient` API
calls.
    @tgross
    tgross committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a1bfc03 View commit details
    Browse the repository at this point in the history