UI: Fix allocation count in CSI volumes table #9515
Conversation
The API doesn’t return the ReadAllocs and WriteAllocs for the index query, as discussed here: #9495 (comment) So this removes that, which will cause the allocation count in the table to be 0, as in the bug report.
This will more accurately reflect the API.
The API includes CurrentWriters and CurrentReaders in the collection response, so this uses that instead of counting WriteAllocs and ReadAllocs, which are not returned in the collection. The individual volume response doesn’t include CurrentWriters and CurrentReaders but their absence doesn’t erase the values.
|
This pull request is being automatically deployed with Vercel (learn more). nomad-storybook-and-ui – ./ui🔍 Inspect: https://vercel.com/hashicorp/nomad-storybook-and-ui/r7rmzrzwz |
There was a problem hiding this comment.
I checked this branch out locally to proxy against the real CSI API and it LGTM! Thanks @backspace!
Ember Asset Size actionAs of 94247f3 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
|
Thank you both. I can also confirm that this PR fixes the issue. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
As detailed in #9495, the collection query
GET /v1/volumes?type=csidoesn’t returnReadAllocsandWriteAllocs, so the# Allocscell was always showing0upon first load because it was derived from the lengths of those arrays. This uses the heretofore-ignoredCurrentReadersandCurrentWritersvalues to calculate the total instead.The single-resource query
GET /v1/volume/csi%2F:iddoesn’t returnCurrentReadersandCurrentWritersbut you can see here that the missing values don’t cause the already-fetched ones to be deleted.Thanks to @apollo13 for reporting this in #9495 and to @tgross for the API logs and suggestion.