Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Change ember-cli-babel to include external helpers #9577

Closed
wants to merge 1 commit into from
Closed

UI: Change ember-cli-babel to include external helpers #9577

wants to merge 1 commit into from

Conversation

backspace
Copy link
Contributor

This is an experiment thanks to a tip from @maxfierke on
the Ember Discord:
https://discord.com/channels/480462759797063690/486548111221719040/785857236546748446

@backspace backspace self-assigned this Dec 8, 2020
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Ember Asset Size action

As of 2f62478

Files that got Bigger 🚨:

File raw gzip
vendor.js +4.86 kB +4.19 kB

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -327 kB -31.5 kB

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Ember Test Audit comparison

master 2f62478 change
passes 1541 1541 0
failures 0 0 0
flaky 0 0 0
duration 7m 25s 201ms 7m 44s 226ms +19s 025ms

backspace added a commit that referenced this pull request Dec 8, 2020
@backspace
Remove support for IE11
22491a9 
This is another angle on #9577, since the helpers in question
there are only present for IE.

Thanks to @pichfl for this solution to an Uglify problem.
@backspace backspace mentioned this pull request Dec 8, 2020
Merged
@backspace
Copy link
Contributor Author

Closing in favour of #9578

@backspace backspace closed this Feb 2, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@backspace backspace

Labels
theme/cleanup theme/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@backspace