Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: Fix node count bug from GH-9566 #9625

Merged
merged 3 commits into from
Dec 14, 2020
Merged

debug: Fix node count bug from GH-9566 #9625

merged 3 commits into from
Dec 14, 2020

Conversation

davemay99
Copy link
Contributor

nodesFound total count was incorrectly reset instead of incremented during each iteration over the node list.

@davemay99 davemay99 linked an issue Dec 12, 2020 that may be closed by this pull request
nomad operator debug: incorrect node count summary #9566
Closed
tgross
tgross approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

command/operator_debug_test.go
"Node Class: clientb",
"Created debug archive",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of these outputs don't seem to reflect the order they're emitted? The test doesn't assert an order either, but do we care about that at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rearranged the outputs to match the order they are written to the screen, but that was just for clarity and consistency. The order really doesn't matter.

@davemay99 davemay99 merged commit 8038641 into master Dec 14, 2020
@davemay99 davemay99 deleted the b-node-count branch December 14, 2020 20:02
schmichael pushed a commit that referenced this pull request Dec 16, 2020
@davemay99 @schmichael
debug: Fix node count bug from GH-9566 (#9625)
6baca75 
* debug: update test to identify bug in GH-9566
* debug: range tests need fresh cmd each iteration
* debug: fix node count bug in GH-9566
schmichael added a commit that referenced this pull request Dec 16, 2020
@schmichael
docs: add #9625 to changelog
9a8bc7e
schmichael added a commit that referenced this pull request Dec 16, 2020
@schmichael
Merge pull request #9653 from hashicorp/docs-9625-changelog
0fd2392 
docs: add #9625 to changelog
backspace pushed a commit that referenced this pull request Jan 22, 2021
@schmichael @backspace
docs: add #9625 to changelog
9a1020c
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nomad operator debug: incorrect node count summary
2 participants
@davemay99 @tgross