Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement mdx remote #9638

Merged
merged 4 commits into from
Jan 6, 2021
Merged

implement mdx remote #9638

merged 4 commits into from
Jan 6, 2021

Conversation

jescalan
Copy link
Contributor

@jescalan jescalan commented Dec 15, 2020 •
edited

Implements this RFC!

Preview the site here: https://nomad-3038bs301.vercel.app/

tgross
tgross approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked the preview (in particular anywhere there were content edits and places I know there are banners or other fancy bits). LGTM

@notnoop notnoop mentioned this pull request Dec 15, 2020
Merged
@jescalan jescalan added the theme/website nomadproject.io infrastructure issues and enhancements label Dec 16, 2020
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui January 6, 2021 00:03 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui January 6, 2021 00:08 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui January 6, 2021 00:40 Inactive
DingoEatingFuzz
DingoEatingFuzz approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit: :shipit: :shipit: :shipit:

My only comment is of the fyi variety. I'm excited to see this merge!

website/data/intro-navigation.js
@@ -10,6 +10,33 @@ export default [
{ category: 'vs', content: ['ecs', 'mesos', 'terraform'] },
{
category: 'getting-started',
content: ['running', 'jobs', 'cluster', 'ui', 'next-steps'],
name: 'Getting Started',
content: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth, the intro page is no longer linked to from anywhere (though it's still in search results).

Copy link
Contributor Author

@jescalan jescalan Jan 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know - we can definitely remove it if the team feels like that's the right move. I just didn't feel like that was my choice to make 😅

@jescalan jescalan merged commit caa21c2 into master Jan 6, 2021
@jescalan jescalan deleted the je.mdx-remote branch January 6, 2021 16:55
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DingoEatingFuzz DingoEatingFuzz DingoEatingFuzz approved these changes

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
theme/website nomadproject.io infrastructure issues and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jescalan @DingoEatingFuzz @tgross