-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement mdx remote #9638
implement mdx remote #9638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot-checked the preview (in particular anywhere there were content edits and places I know there are banners or other fancy bits). LGTM
77d5b66
to
801098e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is of the fyi variety. I'm excited to see this merge!
@@ -10,6 +10,33 @@ export default [ | |||
{ category: 'vs', content: ['ecs', 'mesos', 'terraform'] }, | |||
{ | |||
category: 'getting-started', | |||
content: ['running', 'jobs', 'cluster', 'ui', 'next-steps'], | |||
name: 'Getting Started', | |||
content: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, the intro page is no longer linked to from anywhere (though it's still in search results).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know - we can definitely remove it if the team feels like that's the right move. I just didn't feel like that was my choice to make 😅
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Implements this RFC!
Preview the site here: https://nomad-3038bs301.vercel.app/