Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: always include task services hook #9720

Merged
merged 3 commits into from
Jan 5, 2021
Merged

consul: always include task services hook #9720

merged 3 commits into from
Jan 5, 2021

Commits on Jan 5, 2021

  1. consul: always include task services hook 

    Previously, Nomad would optimize out the services task runner
hook for tasks which were initially submitted with no services
defined. This causes a problem when the job is later updated to
include service(s) on that task, which will result in nothing
happening because the hook is not present to handle the service
registration in the .Update.

Instead, always enable the services hook. The group services
alloc runner hook is already always enabled.

Fixes #9707
    @shoenig
    shoenig committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    5e156d5 View commit details
    Browse the repository at this point in the history

  2. docs: add changelog entry

    @shoenig
    shoenig committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    0f27c13 View commit details
    Browse the repository at this point in the history

  3. e2e: add e2e test for service registration

    @shoenig
    shoenig committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    33527b1 View commit details
    Browse the repository at this point in the history