Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: avoid NPE from unset connect gateway proxy #9727

Merged
merged 2 commits into from
Jan 5, 2021
Merged

consul/connect: avoid NPE from unset connect gateway proxy #9727

merged 2 commits into from
Jan 5, 2021

Commits on Jan 5, 2021

  1. consul/connect: avoid NPE from unset connect gateway proxy 

    Submitting a job with an ingress gateway in host networking mode
with an absent gateway.proxy block would cause the Nomad client
to panic on NPE.

The consul registration bits would assume the proxy stanza was
not nil, but it could be if the user does not supply any manually
configured envoy proxy settings.

Check the proxy field is not nil before using it.

Fixes #9669
    @shoenig
    shoenig committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    80d07f6 View commit details
    Browse the repository at this point in the history

  2. docs: update changelog

    @shoenig
    shoenig committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    d57b390 View commit details
    Browse the repository at this point in the history