Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: move namespace tests into OSS. #9744

Merged
merged 1 commit into from
Jan 7, 2021
Merged

e2e: move namespace tests into OSS. #9744

merged 1 commit into from
Jan 7, 2021

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jan 7, 2021

As noted within #9135 these should be moved into OSS.

The move includes lint fixes that were all ineffassign to err when running commands.

Local testing:

    --- PASS: TestE2E/Namespaces (10.24s)
        --- PASS: TestE2E/Namespaces/*namespaces.NamespacesE2ETest (10.16s)
            --- PASS: TestE2E/Namespaces/*namespaces.NamespacesE2ETest/TestNamespacesFiltering (10.03s)

@jrasell jrasell added type/enhancement theme/testing Test related issues labels Jan 7, 2021
@jrasell jrasell self-assigned this Jan 7, 2021
tgross
tgross approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jrasell!

When we merge this, there'll be a build failure on ENT during the nightly merge, so we'll want to do one manually to remove the namespace_ent.go file.

@jrasell jrasell merged commit 08af8eb into master Jan 7, 2021
@jrasell jrasell deleted the f-add-namespace-e2e-oss branch January 7, 2021 16:36
@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@schmichael schmichael Awaiting requested review from schmichael

Assignees

@jrasell jrasell

Labels
theme/testing Test related issues type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrasell @tgross