Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent double job status update; periodic job count miscalculation #9768

Merged
merged 7 commits into from
Jan 22, 2021
Merged

prevent double job status update; periodic job count miscalculation #9768

merged 7 commits into from
Jan 22, 2021

Commits on Jan 22, 2021

  1. Prevent Job Statuses from being calculated twice 

    #8435 introduced atomic eval
insertion iwth job (de-)registration. This change removes a now obsolete
guard which checked if the index was equal to the job.CreateIndex, which
would empty the status. Now that the job regisration eval insetion is
atomic with the registration this check is no longer necessary to set
the job statuses correctly.
    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    0292a97 View commit details
    Browse the repository at this point in the history

  2. test to ensure only single job event for job register

    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    2555e68 View commit details
    Browse the repository at this point in the history

  3. periodic e2e

    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    1fb755a View commit details
    Browse the repository at this point in the history

  4. separate job update summary step

    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    d1aebcc View commit details
    Browse the repository at this point in the history

  5. fix updatejobstability to use copy instead of modified reference of job

    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    a34d5d3 View commit details
    Browse the repository at this point in the history

  6. update envoygatewaybindaddresses copy to prevent job diff on null vs … 

    …empty
    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    f771258 View commit details
    Browse the repository at this point in the history

  7. set ConsulGatewayBindAddress to empty map instead of nil 

    fix nil assertions for empty map

rm unnecessary guard
    @drewbailey
    drewbailey committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    f35eee3 View commit details
    Browse the repository at this point in the history