Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: Enable running multiple ingress gateways per Nomad agent #9849

Merged
merged 4 commits into from
Jan 20, 2021
Merged

consul/connect: Enable running multiple ingress gateways per Nomad agent #9849

merged 4 commits into from
Jan 20, 2021

Commits on Jan 19, 2021

  1. consul/connect: Enable running multiple ingress gateways per Nomad agent 

    Connect ingress gateway services were being registered into Consul without
an explicit deterministic service ID. Consul would generate one automatically,
but then Nomad would have no way to register a second gateway on the same agent
as it would not supply 'proxy-id' during envoy bootstrap.

Set the ServiceID for gateways, and supply 'proxy-id' when doing envoy bootstrap.

Fixes #9834
    @shoenig
    shoenig committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    7ff2f9c View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. client: use closed variable in append

    @shoenig
    shoenig committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    071060f View commit details
    Browse the repository at this point in the history

  2. consul/connect: ensure proxyID in test case

    @shoenig
    shoenig committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    0019f2c View commit details
    Browse the repository at this point in the history

  3. docs: fix typo in changelog 

    Co-authored-by: Tim Gross <tgross@hashicorp.com>
    @shoenig @tgross
    shoenig and tgross committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    1b8d8b1 View commit details
    Browse the repository at this point in the history