UI: Show allocation associations in the topo viz more often (and fix a bug) #9906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be shown at all
On very small clusters, the node count heuristic is impractical and leads to confusion. By additionally requiring 10+ sibling allocs, the lines will be shown more often.
Ember Asset Size actionAs of ac758a7 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
backspace
approved these changes
Jan 27, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9769
This fixes the bug reported in the above issue and hopefully also clears up some of the confusing behavior.
Bug
When allocation associations aren't supposed to be drawn, resizing the window will cause them to be drawn anyway.
Confusion
Sometimes allocation associations aren't supposed to be drawn but it's not clear when or why.
The motive behind this behavior is the lines can become more overwhelming than they are helpful for densely placed allocs on large clusters. The lines are supposed to help get a sense of spread, but when it's just spaghetti, it's not solving that anymore.
I think this motive is still valid, but the logic behind it is admittedly naive. Before this pr, the logic was
allocCount < nodeCount * 0.75And as you can see in the issue, this means three allocs on a three node cluster don't get lines. Having lines in this scenario isn't at all overwhelming, so I adjusted the logic.Now lines will always be drawn if the sibling alloc count is <10.