Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Use server-sent error messages when applicable #9909

Merged
merged 4 commits into from
Jan 28, 2021
Merged

UI: Use server-sent error messages when applicable #9909

merged 4 commits into from
Jan 28, 2021

Commits on Jan 28, 2021

  1. Improve the message-from-adapter-error util 

    Automatically detect ACL errors
Provide a generic error message as a fallback
    @DingoEatingFuzz
    DingoEatingFuzz committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    6c98f1b View commit details
    Browse the repository at this point in the history

  2. Don't use generic ACL error messages 

    When the error is actually a 403, an ACL error is appropriate, but when
it isn't, fallback on what the API returns.
    @DingoEatingFuzz
    DingoEatingFuzz committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    dbf826d View commit details
    Browse the repository at this point in the history

  3. Test coverage for the messageFromAdapterError util

    @DingoEatingFuzz
    DingoEatingFuzz committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    5dfa556 View commit details
    Browse the repository at this point in the history

  4. Add an acceptance test exercising errors from an HTTP response to a n… 

    …otification
    @DingoEatingFuzz
    DingoEatingFuzz committed Jan 28, 2021
    1 Configuration menu
    Copy the full SHA
    3aa4cf3 View commit details
    Browse the repository at this point in the history