Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change exec URLs to use job’s namespace/region #9968

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

backspace
Copy link
Contributor

This closes #9966. It was looking at the query parameters
for the namespace and region, but allocation (and task!)
routes don’t have a namespace query parameter. Since the URL
generator requires the job for all calls, it makes sense to
extract the namespace and region from the job instead.

This closes #9966. It was looking at the query parameters
for the namespace and region, but allocation (and task!)
routes don’t have a namespace query parameter. Since the URL
generator requires the job for all calls, it makes sense to
extract the namespace and region from the job instead.
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Ember Asset Size action

As of 3619d53

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +67 B +40 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Ember Test Audit comparison

master 3619d53 change
passes 1551 1551 0
failures 0 0 0
flaky 0 0 0
duration 8m 16s 817ms 7m 38s 905ms -37s 912ms

Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, quick turnaround on this. Nice work.

@backspace backspace merged commit 84b8a19 into master Feb 4, 2021
@backspace backspace deleted the b-ui/exec-allocation-namespace branch February 4, 2021 19:14
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exec button in Nomad UI not working from allocation page.
2 participants