Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul/connect: enable custom sidecars to use expose checks #9995

Merged
merged 2 commits into from
Feb 9, 2021
Merged

consul/connect: enable custom sidecars to use expose checks #9995

merged 2 commits into from
Feb 9, 2021

Commits on Feb 9, 2021

  1. consul/connect: enable custom sidecars to use expose checks 

    This PR enables jobs configured with a custom sidecar_task to make
use of the `service.expose` feature for creating checks on services
in the service mesh. Before we would check that sidecar_task had not
been set (indicating that something other than envoy may be in use,
which would not support envoy's expose feature). However Consul has
not added support for anything other than envoy and probably never
will, so having the restriction in place seems like an unnecessary
hindrance. If Consul ever does support something other than Envoy,
they will likely find a way to provide the expose feature anyway.

Fixes #9854
    @shoenig
    shoenig committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    af48777 View commit details
    Browse the repository at this point in the history

  2. docs: fix egregious changelog ordering

    @shoenig
    shoenig committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    bc710d8 View commit details
    Browse the repository at this point in the history