Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary_key_pair_type option has no effect #144

Closed
jsf9k opened this issue Oct 8, 2021 · 2 comments · Fixed by #179
Closed

temporary_key_pair_type option has no effect #144

jsf9k opened this issue Oct 8, 2021 · 2 comments · Fixed by #179
Labels
bug

Comments

@jsf9k
Copy link

jsf9k commented Oct 8, 2021

Overview of the Issue

Although the documentation lists it, the temporary_key_pair_type configuration option does not appear to actually do anything; furthermore, I do not see that option used at all in builder/common/step_key_pair.go.

Reproduction Steps

  1. Create a Packer Buildfile using the AWS EBS builder and include the option "temporary_key_pair_type": "ed25519". (I should mention that I am using a JSON template.)
  2. Run packer
  3. Observe in the AWS Console that the temporary EC2 keypair created is of type RSA.

Plugin and Packer version

v1.7.3

Operating system and Environment details

This is happening in a GitHub Action running Ubuntu 20.04.3 LTS.
@jsf9k jsf9k added the bug label Oct 8, 2021
@lorengordon
Copy link
Contributor

I just came here to report this! Here is the announcement from AWS saying they now support ed25519... https://aws.amazon.com/about-aws/whats-new/2021/08/amazon-ec2-customers-ed25519-keys-authentication/

@lorengordon lorengordon mentioned this issue Oct 21, 2021
Closed
@stephank stephank mentioned this issue Dec 14, 2021
Open
@sbraz sbraz mentioned this issue Dec 24, 2021
Closed
wedge-jarrad added a commit to wedge-jarrad/packer-plugin-amazon that referenced this issue Jan 20, 2022
@wedge-jarrad
Enable temporary_key_pair_type option for ed25519
26a2f3b 
Closes hashicorp#144
This was referenced Jan 20, 2022
Merged
Closed
wedge-jarrad added a commit to wedge-jarrad/packer-plugin-amazon that referenced this issue Jan 23, 2022
@wedge-jarrad
Enable temporary_key_pair_type option for ed25519
87437b8 
Closes hashicorp#144
JenGoldstrich pushed a commit that referenced this issue Jan 24, 2022
@wedge-jarrad
Enable temporary_key_pair_type option for ed25519 (#179)
47325f9 
* Enable temporary_key_pair_type option for ed25519

Closes #144

* Improve temporary_key_pair_type validation

Default to "rsa" if not given. Error if a value other than "rsa" or "ed25519"
is given.

* Add tests for temporary_key_pair_type

* go fmt
@rubenanapu
Copy link

To make the temporary_key_pair_type key work on Amazon, I had to use specifically Packer 1.8.0, as explained in the link below:

hashicorp/packer#10074 (comment)

I previously tried Packer 1.2.4, 1.3.2, and 1.11.1 and none of them allowed me to use the temporary_key_pair_type key, but with Packer 1.8.0 it worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable temporary_key_pair_type option for ed25519 wedge-jarrad/packer-plugin-amazon
3 participants
@jsf9k @lorengordon @rubenanapu