generated from hashicorp/packer-plugin-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump packer-plugin-sdk to address legacy SSH key algorithms in SSH communicator #218
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
40 changes: 40 additions & 0 deletions
40
builder/ebs/test-fixtures/ssh-keys/rsa_sha2_only_server.pkr.hcl
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| OpenSSH migrated the ssh-rsa key type, which historically used the ssh-rsa | ||
| signature algorithm based on SHA-1, to the new rsa-sha2-256 and rsa-sha2-512 signature algorithms. | ||
|
|
||
| Golang issues: https://github.com/golang/go/issues/49952 | ||
|
|
||
| See plugin issue: https://github.com/hashicorp/packer-plugin-amazon/issues/213 | ||
| */ | ||
|
|
||
| data "amazon-ami" "autogenerated_1" { | ||
| filters = { | ||
| name = "ubuntu/images/hvm-ssd/ubuntu-jammy-22.04-amd64-server-*" | ||
| root-device-type = "ebs" | ||
| virtualization-type = "hvm" | ||
| } | ||
| most_recent = true | ||
| owners = ["099720109477"] | ||
| region = "us-east-1" | ||
| } | ||
|
|
||
| locals { timestamp = regex_replace(timestamp(), "[- TZ:]", "") } | ||
|
|
||
| source "amazon-ebs" "basic-example" { | ||
| ami_description = "Ubuntu 22.04 GoldenImage" | ||
| ami_name = "ubuntu-22.04-${local.timestamp}" | ||
| instance_type = "t3.micro" | ||
| region = "us-east-1" | ||
| source_ami = "${data.amazon-ami.autogenerated_1.id}" | ||
| ssh_username = "ubuntu" | ||
| skip_create_ami = true | ||
| } | ||
|
|
||
| build { | ||
| sources = ["source.amazon-ebs.basic-example"] | ||
|
|
||
| provisioner "shell" { | ||
| inline = ["echo Successful login"] | ||
| } | ||
|
|
||
| } | ||
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know this one tests what you need because of the ubuntu version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this particular version of ubuntu runs openssh version 8.9 which requires stronger ssh key algorithms, as of openssh 8.8. I added a comment to the HCL file. But maybe I should add one here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good the way it is!!