common: fix subnet_filters when public IP set #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 1.2.3 of the AWS plugin, we changed the way we set the subnet when the associate_public_ip_address argument is not unset. This had the side-effect of breaking configuration which specified a subnet_id or a subnet_filter, as it would always default on inferring the most available one from the default (or selected) VPC. This was a bug, and is fixed with this commit.
JenGoldstrich
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
This largely LGTM but I would consider adding unit test for step_network_info, I'm not super familiar with how complex that would be on the Amazon plugin so feel free to disregard this if its complex, but since this caused a regression it might be worth adding a unit test to this in the future.
|
Right now since we don't have any kind of architecture for unit-testing this step, we won't do it, especially since this broke the plugin for a fair amount of users, so we opted to rely on acceptance testing for this time. |
|
@JenGoldstrich @lbajolet-hashicorp I opened #371 to track the unit tests for this code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.2.3 of the AWS plugin, we changed the way we set the subnet when the associate_public_ip_address argument is not unset.
This had the side-effect of breaking configuration which specified a subnet_id or a subnet_filter, as it would always default on inferring the most available one from the default (or selected) VPC.
This was a bug, and is fixed with this commit.
Closes #367
Related to #368