Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade aws-sdk-go to fix SSO issue #415

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

paulojmdias
Copy link
Contributor

@paulojmdias paulojmdias commented Sep 11, 2023

Upgrading aws-sdk-go to fix the issue with usage with SSO.

Tested with the following configuration:

[profile dummy]
sso_session = dummy
sso_account_id = REDACTED
sso_role_name = dummy-role
region = us-east-1
output = json

[sso-session dummy]
sso_start_url = https://d-REDACTED.awsapps.com/start#
sso_region = us-east-1
sso_registration_scopes = sso:account:access

Closes #350

@paulojmdias paulojmdias requested a review from a team as a code owner September 11, 2023 13:20
@paulojmdias
Copy link
Contributor Author

@nywilken sorry for ping you, but can you please review it? 🙏

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulojmdias thanks for the ping and my apologies for the delayed review. Our focus has been on Packer core these past few weeks. This looks good to me. Thank you for making the fix.

I'll pull this down to run some quick testing before merging.

@nywilken nywilken merged commit f81ba26 into hashicorp:main Sep 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use AWS SSO auth with sso-session profile
2 participants