Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support site and region_code arguments #54

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

wonchulee
Copy link
Contributor

@wonchulee wonchulee commented Feb 13, 2023

Hello,
I'm a terraform/packer provider developer for NCloud.

To make things easier for users, It introduced two packer arguments.

Provider's site argument has been added. The'site' option in ncloud-sdk-go-v2 is used to set the destination site API gateway address.

Additionally, the region-code parameter has been around for a while but has never been used. Users can use region code rather than region.

@wonchulee wonchulee requested a review from a team as a code owner February 13, 2023 07:34
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@sangkyu-kim sangkyu-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sangkyu-kim
Copy link
Contributor

@nywilken Hello, can you help to merge this branch? and I'm curious about the review process and deploy cycle of this repository.

Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wonchulee this looks good to go. Thank you for the contribution.

@nywilken nywilken merged commit b1e1745 into hashicorp:main Feb 23, 2023
@nywilken nywilken changed the title feat: Support site and region_code arguments Support site and region_code arguments Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants