Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo SSHHostPort Config-not-required.mdx #161

Merged

Conversation

HolyFredy
Copy link
Contributor

Code blocks for HCL2 and JSON in SSHHostPort exemple were not separated

@HolyFredy HolyFredy requested a review from a team as a code owner October 27, 2023 08:00
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HolyFredy,

Good catch, thanks for fixing this one!

@lbajolet-hashicorp lbajolet-hashicorp added the documentation Improvements or additions to documentation label Oct 27, 2023
Code blocks for HCL2 and JSON in SSHHostPort exemple were not separated
@lbajolet-hashicorp lbajolet-hashicorp force-pushed the HolyFredy-Docs-SSHHostPort branch from ac6796e to e155dcb Compare October 27, 2023 13:29
@lbajolet-hashicorp
Copy link
Contributor

FYI: I changed the code of your commit a bit, you modified a generated file (which I would have not seen if there wasn't a generate check!), the docs to modify would be in the builder/qemu/config.go file, since they get compiled into mdx partials, which are then included by the docs page.

With this the generate check should be happy, and we'll have up-to-date docs.

@lbajolet-hashicorp lbajolet-hashicorp merged commit 8276c5d into hashicorp:main Oct 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants