-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support many files in Vagrant box for libvirt #48
Support many files in Vagrant box for libvirt #48
Conversation
b6ec955
to
0c18dff
Compare
0c18dff
to
56ef105
Compare
@LeConTesteur @electrofelix apologies for the delayed review on this PR. I'm slating it for review so that a member of the team can follow up with the original issue and requested changes. Thanks again for pushing this plugin forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LeConTesteur,
As I mentioned in the related issue, sorry for the delay in the review, and thanks for submitting this PR.
Given what we know about the qemu builder, which is the only one producing artifacts that will be processed by this code, there's currently only one image in the output, so we can rely on this to include only the image itself, and not the potential extra efivars.fd
raw blob in the volume list.
Additionally, since we've taken so long to merge this, the code conflicts with a change made a while back on the filename check, so that'll have to be fixed before we can merge this PR.
Please let me know if you're still interested to work on this PR, I'll happily review the changes once you're ready.
Otherwise, please let me know and I can continue working on supporting this change.
9136750
to
54e2ab3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LeConTesteur,
Thanks for the reroll, with the discussion ongoing in the related issue, I'm more confident this code will work as intended, I just left a few suggestions/nits, but overall this looks good to me.
dd34eb5
to
7a80cd5
Compare
7a80cd5
to
967d92a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me now @LeConTesteur, thanks for rerolling this.
I'll merge the PR today
Hello,
I try to implement this issue hashicorp/packer#10627.
Now, we use this format for
metadata.json
:I append new tests.
Closes #10627