Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sshkey package and ssh-keygen comand #10101

Merged
merged 13 commits into from
Oct 19, 2020
Merged

add sshkey package and ssh-keygen comand #10101

merged 13 commits into from
Oct 19, 2020

Conversation

azr
Copy link
Contributor

@azr azr commented Oct 14, 2020

This is preliminary work for #10074 next: refactor plugins that generate their own ssh keypair to start using this.

This brings:

  • a helper/communicator/sshkey package that has a sshkey.GeneratePair function that will allow to generate valid open ssh keypairs.
  • a cmd/ssh-keygen package that is a simplified go version of ssh-keygen to test the pairs with real ssh servers.
  • go tests to see wether the keypairs can be parsed, although a 'real' ssh server/client is a much better way to test.

@azr azr requested a review from a team as a code owner October 14, 2020 13:52
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #10101 into master will increase coverage by 0.10%.
The diff coverage is 68.50%.

Impacted Files Coverage Δ
helper/communicator/sshkey/algorithm_enumer.go 11.11% <11.11%> (ø)
helper/communicator/sshkey/generate.go 74.17% <74.17%> (ø)
packer/communicator.go 76.59% <0.00%> (+2.12%) ⬆️

@SwampDragons
Copy link
Contributor

Cool! This is a bit lower-level than I'd expected you'd have to get. But looks good. Can't wait to see it in action.

@azr
Copy link
Contributor Author

azr commented Oct 19, 2020

Same here ! Hopefully the cryptography is still handled by the "crypto" packages and I just had to work on wrapping/unwrapping 🙂 .

@azr azr merged commit b249116 into master Oct 19, 2020
@azr azr deleted the azr_pick_keygen_type branch October 19, 2020 08:24
@SwampDragons SwampDragons added this to the 1.6.5 milestone Oct 19, 2020
@SwampDragons SwampDragons added the core Core components of Packer label Oct 21, 2020
@ghost
Copy link

ghost commented Nov 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Core components of Packer enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants