fix security hole with ami filter

[SwampDragons]

Make "owners" field required on source_ami_filter.

Closes #6584

[rickard-von-essen]

👍

[mwhooker]

👍

[iam-decoder]

owners is required now, however, if I set my source filter like so:

    "source_ami_filter": {
      "filters": {
        "name": "ubuntu/images/*ubuntu-*-{{user `os_version`}}-amd64-server-*",
        "owners": "099720109477"
      }
    }

then I get the error:

1 error(s) occurred:

* For security reasons, your source AMI filter must declare an owner.'

if i set my source filter to this:

    "source_ami_filter": {
      "filters": {
        "name": "ubuntu/images/*ubuntu-*-{{user `os_version`}}-amd64-server-*",
        "owners": ["099720109477"]
      }
    }

then I get the error:

1 error(s) decoding:

* '\''source_ami_filter.Filters[owners]'\'' expected type '\''string'\'', got unconvertible type '\''[]interface {}'\'''

[SwampDragons]

"owners" goes outside of that filters block. Try this instead:

    "source_ami_filter": {
      "filters": {
        "name": "ubuntu/images/*ubuntu-*-{{user `os_version`}}-amd64-server-*",
      }
"owners": ["099720109477"]
    }

[iam-decoder]

misread docs, thanks! I just converted my owner-id filter to owners haha

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.