-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes checksum for dependencies for Go 1.11.4+ #7261
Conversation
I tested this PR agains Go 1.11.5. |
Hey there @davividal, thanks for taking the time to do this. I need to double check a something still looks odd. ❯ go version
go version go1.11.5 darwin/amd64
❯ rm -rf ~/go/pkg/mod/cache
❯ GO111MODULE=on go mod download
...
go: finding github.com/oklog/run v1.0.0
go: verifying github.com/gotestyourself/gotestyourself@v2.2.0+incompatible: checksum mismatch
downloaded: h1:AQwinXlbQR2HvPjQZOmDhRqsv5mZf+Jb1RnSLxcqZcI=
go.sum: h1:1yOKgt0XYKUg1HOKunGOSt2ocU4bxLCjmIHt0vRtVHM=
... Edit: will try to fix it, oh dear, these downloads take forever ! |
All good, thanks !!!! 🙂 |
@davividal @azr I encounter same issue here with current master branch. ➜ packer git:(master) ✗ go version ➜ packer git:(master) ✗ uname -a And it prints following errors:
It seems caused by change in #7261 |
Yes, currently go modules and go vendors have a bit diverged. #7270 should sort this out. |
@azr I'm little confused here. Since I ran |
go modules are still considered experimental, it could be that checksums are different between GOOSes kubernetes/kubernetes#69040, more: golang/go#27925 |
@azr Thanks for the info. That is helpful. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Closes #7242
Quoting golang/go#29278 (comment):