hyper-v fix when management interface is not part of virtual switch #8017
Conversation
|
|
common/powershell/hyperv/hyperv.go
Outdated
| } | ||
| else { | ||
| return $false | ||
| } |
There was a problem hiding this comment.
Not sure what's happened but could you fix the formatting here? The original code used an indent of four spaces rather than tabs
There was a problem hiding this comment.
Sure, don't know why my vscode formatted it this way.
|
This looks good, except for needing that indentation fix that Dan mentioned. I'm not sure why tests are failing -- I'm investigating now. |
|
Hi guys, do I need to do something more? |
|
Ah, sorry for dropping the ball on this! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
hyper-v fix when management interface is not part of virtual switch
This PR resolves situation when VirtualSwitch used for VM creation is not set as 'management' - de facto doesn't have it's own IP.
Instead of defaulting to
falselet's get an IP from default non locahost interface and use it as IP for packer http serverCloses #5023