Skip to content

Commit

Permalink
Merge pull request #4434 from hashicorp/bugfix/workaround-for-inconsi…
Browse files Browse the repository at this point in the history
…stent-model-field-description

importer-rest-api-specs: temporary workaround for #3325 to avoid flapping diff in API definitions
  • Loading branch information
manicminer authored Sep 23, 2024
2 parents e09df94 + 128cd0f commit 345b393
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tools/importer-rest-api-specs/components/parser/models.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,12 @@ func (d *SwaggerDefinition) detailsForField(modelName string, propertyName strin
result.Append(known)

field := sdkModels.SDKField{
Required: isRequired,
Optional: !isRequired, //TODO: re-enable readonly && !value.ReadOnly,
ReadOnly: false, // TODO: re-enable readonly value.ReadOnly,
Sensitive: false, // todo: this probably needs to be a predefined list, unless there's something we can parse
JsonName: propertyName,
Description: value.Description,
Required: isRequired,
Optional: !isRequired, //TODO: re-enable readonly && !value.ReadOnly,
ReadOnly: false, // TODO: re-enable readonly value.ReadOnly,
Sensitive: false, // todo: this probably needs to be a predefined list, unless there's something we can parse
JsonName: propertyName,
//Description: value.Description, // TODO: currently causes flapping diff in api definitions, see https://github.com/hashicorp/pandora/issues/3325
}

// first get the object definition
Expand Down

0 comments on commit 345b393

Please sign in to comment.