Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data API V2: Refactor the data API models under sdk/dataapimodels #3375

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Nov 17, 2023

I chose to put these under the folder dataapimodels instead of v1models since I think the term v1 is unclear and has the potential to be confusing given that we use v1 for versioning several things, e.g. endpoint within the data api as well as the old and new versions of the data api (data api v2)

If we need to add more models for a new version of the endpoint e.g. v2 we can reconsider the naming then. But for the forseeable future this is sufficient and clearer.

The removal of the models in the data-api tool will happen in a follow up PR when these models can be vendored into the project.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stephybun stephybun merged commit 4b07392 into main Nov 20, 2023
@stephybun stephybun deleted the r/refactor-data-api-models branch November 20, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants