automation: updating the Terraform Generator to use Data API V2 #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behaviour used by both the Go SDK and Terraform Generators, so by assuming that each of these is available on the path - this is easier to reproduce locally by being all done within the bash script.
…finitions` directory This matches the behaviour of the Data API - and means the scripts can pass this in
… and updating the Terraform Generator to use Data API v2
tombuildsstuff
added
tool/generator-terraform
tombuildsstuff
deleted the
automation/refactor-and-enable-data-api-v2-for-terraform-generator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also updates the way the
data-apitool is built and launched to match the way thegenerator-go-sdkandgenerator-terraformtools are built/launched (that is, installing them onto the$GOBIN) - meaning that the shell scripts contain all of the dependencies needed to launch the Data API v2. This means that the process is now fully reproducible with a fresh checkout, which makes debugging issues simpler.Notably as a part of doing this the
wrapper-automationtool now takes the path to the API Definitions directory, matching the behaviour of Data API V2.Finally this PR cleans up the Github Action for the Go SDK Generator, so that we no longer build V1 of the Data API (since this is no longer using it).