tools/importer-rest-api-specs: refactoring / removing usages of _some_ of the old Terraform models
#3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added
bug
… to use the new SDK
… Definition to come from the new SDK
…compile-time errors for incorrect assignments
tombuildsstuff
force-pushed
the
refactor/arm-importer-terraform-1
branch
from
87f206b to
dce4715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on from #3904 and updates several of the old SDKs Terraform Models to use the new Data API SDK models. I've tried grouping all of the Terraform changes together and it's too much to change at once - hence splitting this up.
This also fixes some minor bugs where the incorrect Object Definition Types were being used - by changing
typealias ObjectDefinitionTypeName = stringtotypealias ObjectDefinitionTypeName string- to ensure that using anSDKObjectDefinitionTypewhere we're expecting aTerraformSchemaObjectDefinitionType(and visa-versa) would become a compiler error - and finally fixing any compiler errors from this.