importer-rest-api-specs
- data workaround for AlertsManagement
and move call to removeUnusedItems
#4020
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
ActionRules
resource inAlertsManagement
which will allow us to removeAlertsManagement
entirely from the providerremoveUnusedItems
, this was previously called everytime we parsed data associated with a swagger tag, but this results in the removal of models that might need to referenced in data workarounds.removeUnusedItems
is now called after all the processing has been done for a serviceremoveUnusedItems
to take separate constants and models argument instead of aresult
argument of typeParseResult
removeUnusedItems
in the test helper used for parsing the testdata since it's no longer called iteratively in theparse
function that we're testing. We still need to replicate the whole parsing process for these tests to be able to ensure the behaviour we're expecting is maintainedThe effects of this on the existing API definitions is minimal, all of the changes listed below will not affect any resources in the provider