tools/importer-msgraph-metadata: refactor to generate JSON definitions using data-api-sdk
#4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
added
enhancement
manicminer
force-pushed
the
msgraph-importer-refactor
branch
from
672c15c to
cd22508
Compare
…services, version, resources and operations
… for select services; bodge the models/constants by duplicating them across resources for now
…ersisting common types
manicminer
force-pushed
the
msgraph-importer-refactor
branch
from
cd22508 to
745ad67
Compare
tombuildsstuff
suggested changes
Jun 5, 2024
There was a problem hiding this comment.
hey @manicminer
Thanks for this PR/rebasing this.
I've taken a look through and left some comments inline but on the whole this is looking pretty good - there's 2 main things:
- I think it'd be worth introducing a
RemoveExistingAPIDefinitions()(or similar) function to allow both the MSGraph importer and the ARM importer to clear any existing data prior to performing an import. Whilst there's some benefits to threadingRemoveServicethrough and performing a diff against the dataset to determine what's changed - tbh it's far easier/less code/bug prone to blow away the entire dataset and assume we're working in a clean directory each time. This will necessitate updating both the Graph and ARM importers to call that function prior to importing, but that should be fine? - As discussed offline, can we introduce specific Stages for the
CommonTypesConstantStageandCommonTypesModelsStage? Whilst these'll likely be similar to the existingConstantandModelsstage, doing this means each Stage remains responsible for the files it's creating (and that the paths aren't defined outside of that), which I think is beneficial?
Other than that though this is looking pretty good, nice one 👍
Thanks!
tools/importer-msgraph-metadata/internal/pipeline/task_translate_service.go
Show resolved
Hide resolved
…r `SaveCommonTypes` to use its own stages
…ld type is unknown
…es rather than models
… we will instead use built-in types
…or better Go package/module compatibility and improved usability
manicminer
force-pushed
the
msgraph-importer-refactor
branch
from
98b1ba1 to
f8f7bb6
Compare
manicminer
force-pushed
the
msgraph-importer-refactor
branch
from
f8f7bb6 to
b146da6
Compare
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
tombuildsstuff
approved these changes
Jun 28, 2024
tools/importer-msgraph-metadata/components/normalize/duplicates.go
Outdated
Show resolved
Hide resolved
tools/importer-msgraph-metadata/internal/pipeline/task_translate_service.go
Outdated
Show resolved
Hide resolved
tools/importer-msgraph-metadata/internal/pipeline/task_translate_service.go
Show resolved
Hide resolved
tools/importer-msgraph-metadata/internal/pipeline/task_translate_service.go
Show resolved
Hide resolved
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to Data API will be added in a separate PR- this has been implemented in #4217Currently this should have no net effect on data definitions for Resource Manager.