-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new override and docs for how to add new overrides #4627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @mbfrahry! Could you take a look at the suggestions I made in-line?
...-api-specs/internal/components/apidefinitions/parser/dataworkarounds/workaround_web_31682.go
Outdated
Show resolved
Hide resolved
...-api-specs/internal/components/apidefinitions/parser/dataworkarounds/workaround_web_31682.go
Outdated
Show resolved
Hide resolved
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
…ns/parser/dataworkarounds/workaround_web_31682.go Co-authored-by: stephybun <steph@hashicorp.com>
…ns/parser/dataworkarounds/workaround_web_31682.go Co-authored-by: stephybun <steph@hashicorp.com>
Thanks for taking the time to review all that Steph! Such a struggle getting the words right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mbfrahry LGTM 🍜
This PR adds docs for how to create new overrides and adds a new override for Web