Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new override and docs for how to add new overrides #4627

Merged
merged 16 commits into from
Jan 29, 2025

Conversation

mbfrahry
Copy link
Member

This PR adds docs for how to create new overrides and adds a new override for Web

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @mbfrahry! Could you take a look at the suggestions I made in-line?

docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
docs/data-workarounds.md Outdated Show resolved Hide resolved
mbfrahry and others added 15 commits January 15, 2025 11:32
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
…ns/parser/dataworkarounds/workaround_web_31682.go

Co-authored-by: stephybun <steph@hashicorp.com>
…ns/parser/dataworkarounds/workaround_web_31682.go

Co-authored-by: stephybun <steph@hashicorp.com>
@mbfrahry
Copy link
Member Author

Thanks for taking the time to review all that Steph! Such a struggle getting the words right

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbfrahry LGTM 🍜

@stephybun stephybun merged commit 87639df into main Jan 29, 2025
3 checks passed
@stephybun stephybun deleted the override-web-connections-2016 branch January 29, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants