Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] makePeerInternal() shouldn't default the protocol version #170

Closed
ongardie opened this issue Oct 7, 2016 · 0 comments
Closed

[v2] makePeerInternal() shouldn't default the protocol version #170

ongardie opened this issue Oct 7, 2016 · 0 comments
Milestone
v2

Comments

@ongardie
Copy link
Contributor

ongardie commented Oct 7, 2016

we should always configure a protocol version at this level (and 0 is a valid version)
@slackpad slackpad added this to the v2 milestone Oct 7, 2016
@slackpad slackpad mentioned this issue Oct 7, 2016
Closed
14 tasks
ongardie-sfdc pushed a commit to ongardie/hashicorp-raft that referenced this issue Oct 31, 2016
@ongardie
peer: Require protocolVersion
5ccb376 
Close hashicorp#170: makePeerInternal() shouldn't default the protocol version
@ongardie-sfdc ongardie-sfdc mentioned this issue Oct 31, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@ongardie @slackpad