Add a config option specifying no snapshot restore on startup #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| r.logger.Info(fmt.Sprintf("Restored from snapshot %v", snapshot.ID)) | ||
| } | ||
| // Update the lastApplied so we don't replay old logs | ||
| r.setLastApplied(snapshot.Index) |
There was a problem hiding this comment.
Is it correct to leave this here since nothing was actually restored?
| if err != nil { | ||
| // Same here, skip and try the next one. | ||
| continue | ||
| } | ||
| } | ||
|
|
||
| snapshotIndex = snapshot.Index |
There was a problem hiding this comment.
Is it correct to leave this here since nothing was actually restored?
|
@i0rek Good question, yeah we still need a way to tell Raft which index the FSM is currently at even if we don't need to restore a snapshot to the FSM. This way if there are still pending logs they will be replayed on top of the FSM. The Snapshot Metadata is still used to do this. In Vault's case the snapshot metadata represents the current state of the FSM. |
hanshasselberg
approved these changes
Jun 19, 2019
|
Test failure just normal flakiness; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.