Deprecate Staging suffrage and Promote command #486
Conversation
Replace it with AddVoter, which is how this has worked for the last 5 years. This change should be backwards compatible. The old commands still work, but are now an alias for AddVoter.
| // AddVoter: was missing. | ||
| {Configuration{}, AddVoter, 1, "{[{Voter id1 addr1}]}"}, | ||
| {singleServer, AddVoter, 2, "{[{Voter id1 addr1x} {Voter id2 addr2}]}"}, | ||
| // AddVoter: was Voter. | ||
| {singleServer, AddVoter, 1, "{[{Voter id1 addr1}]}"}, | ||
| // AddVoter: was Staging. | ||
| {oneOfEach, AddVoter, 2, "{[{Voter id1 addr1x} {Voter id2 addr2} {Nonvoter id3 addr3x}]}"}, | ||
| // AddVoter: was Nonvoter. | ||
| {oneOfEach, AddVoter, 3, "{[{Voter id1 addr1x} {Staging id2 addr2x} {Voter id3 addr3}]}"}, | ||
|
|
There was a problem hiding this comment.
This is just copy/paste of the AddStaging test cases above, with the second field change. I left the original test cases to show backwards compat.
| r.logger.Warn("clearing log suffix", | ||
| "from", entry.Index, | ||
| "to", lastLogIdx) | ||
| r.logger.Warn("clearing log suffix", "from", entry.Index, "to", lastLogIdx) |
There was a problem hiding this comment.
Unrelated cleanup I had done while reading the code. This log line fits pretty easily on one line.
There was a problem hiding this comment.
I've seen this done stylistically to better show the pairing of variadic args (which I think reads better but this one is short enough not to be confusing)
| // AddStaging makes a server a Voter. | ||
| // Deprecated: AddStaging was actually AddVoter. Use AddVoter instead. | ||
| AddStaging = 0 // explicit 0 to preserve the old value. |
There was a problem hiding this comment.
By keeping the constant value 0 it should be safe to upgrade raft. Because any existing clients will send a 0 in the RPC message, and new clients will also send a 0 using the new AddVoter constant.
AddStagingandPromotewere never used.raft-autopilothandles this promotion without the need for the extra suffrage type.This PR deprecates these constants in a backwards compatible way. It also updates the godoc to remove misleading suggestions of code that does not exist. The old TODO is also removes since we no longer plan to do it.