Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CommitIndex API #560

Merged
merged 2 commits into from
Jul 10, 2023
Merged

add CommitIndex API #560

merged 2 commits into from
Jul 10, 2023

Conversation

niebayes
Copy link
Contributor

This API is useful for implementing the read index optimization as described in the Raft paper.

@niebayes niebayes requested a review from a team as a code owner June 27, 2023 08:15
@niebayes niebayes requested review from mkeeler and removed request for a team June 27, 2023 08:15
@hashicorp-cla
Copy link

hashicorp-cla commented Jun 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@niebayes niebayes mentioned this pull request Jun 27, 2023
Closed
mkeeler
mkeeler approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This already is reported in the Stats map and the underlying values are synchronized appropriately so I see no reason why this value shouldn't be exposed with a direct API.

@mkeeler
Copy link
Member

mkeeler commented Jun 27, 2023

@niebayes I think you will need to sign the HashiCorp CLA before this can be merged.

@niebayes
Copy link
Contributor Author

@mkeeler Hi, I've completed the signature.

@loshz
Copy link
Contributor

loshz commented Jun 30, 2023

@niebayes it looks like you need to run go fmt api.go as there is a slight formatting issue that's blocking CI.

@niebayes
Copy link
Contributor Author

niebayes commented Jul 1, 2023 via email

@niebayes
Copy link
Contributor Author

niebayes commented Jul 1, 2023

@loshz Hi, I've fixed the formatting issue.

@JoanFM
Copy link

JoanFM commented Jul 5, 2023

Hello @mkeeler and @loshz ,

do you have any approximate timeline about when this PR may be merged and added in a release?

@loshz loshz merged commit 3b0f2e5 into hashicorp:main Jul 10, 2023
@otoolep otoolep mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loshz loshz loshz approved these changes

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niebayes @hashicorp-cla @mkeeler @loshz @JoanFM