Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Bump tf to version 1.0 #234

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Bump tf to version 1.0 #234

merged 3 commits into from
Aug 16, 2021

Conversation

bwhaley
Copy link
Contributor

@bwhaley bwhaley commented Aug 12, 2021

Updates tests to use Terraform 1.0.

@bwhaley bwhaley requested a review from robmorgan as a code owner August 12, 2021 17:51
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 12, 2021

CLA assistant check
All committers have signed the CLA.

Copy link

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor

Kicking off build prior to merge

@yorinasub17
Copy link
Contributor

Ah looks like somehow the circleci config got broken along the way 🤦 . Can you update to remove the nightly trigger workflow?

@bwhaley
Copy link
Contributor Author

bwhaley commented Aug 16, 2021

Done. Mind triggering the tests again?

Comment on lines 58 to 60
jobs:
- build
- test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like you forgot to remove this subkey of the nightly-test workflow.

@bwhaley
Copy link
Contributor Author

bwhaley commented Aug 16, 2021

Oh, whoops! Fixed.

@yorinasub17
Copy link
Contributor

Looks like the build is going now!

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build passed! Going to merge this in.

@yorinasub17 yorinasub17 merged commit e9ceb57 into hashicorp:master Aug 16, 2021
@bwhaley
Copy link
Contributor Author

bwhaley commented Aug 16, 2021

Thank you! 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants