This repository has been archived by the owner on Jan 25, 2023. It is now read-only.
use splat syntax in fully_qualified_domain_name output #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlfig
changed the title
fully_qualified_domain_name output
brikis98
suggested changes
Jan 3, 2018
modules/vault-elb/outputs.tf
Outdated
| @@ -15,5 +15,5 @@ output "load_balancer_security_group_id" { | |||
| } | |||
|
|
|||
| output "fully_qualified_domain_name" { | |||
| value = "${aws_route53_record.vault_elb.fqdn}" | |||
| value = "${aws_route53_record.vault_elb.*.fqdn}" | |||
There was a problem hiding this comment.
This will turn this output into a list, which is probably not what we want. You instead need to use the slightly ugly workaround listed here:
value = "${element(concat(aws_route53_record.vault_elb.*.fqdn, list("")), 0)}"There was a problem hiding this comment.
Good point. Wasn't aware of that guide. Have a look.
Keeps fully_qualified_domain_name with type string deals correctly with the case when vault_elb is absent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform >0.11.1 warns about non-splat references to resources with
countdefined.This will become fatal in 0.12 (hashicorp/terraform#16735)
See https://github.com/hashicorp/terraform/blob/v0.11.1/CHANGELOG.md