Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property Mapper should Respect Tokens #835

Closed
Tracked by #525
skorfmann opened this issue Jul 15, 2021 · 1 comment · Fixed by #1791
Closed
Tracked by #525

Property Mapper should Respect Tokens #835

skorfmann opened this issue Jul 15, 2021 · 1 comment · Fixed by #1791
Labels
bug Something isn't working cdktf feature/tokens priority/important-soon High priority, to be worked on as part of our current release or the following one.

Comments

@skorfmann
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

  • all

Affected Resource(s)

  • Lazy / Token

Debug Output

node_modules/cdktf/lib/runtime.js:16
            return x.map(elementMapper);
                     ^

    TypeError: x.map is not a function

Expected Behavior

IResolvable should be skipped here as well

export function canInspect(x: any) {

Actual Behavior

It's trying to map IResolvable values, which fails.

@skorfmann skorfmann added bug Something isn't working cdktf labels Jul 15, 2021
@DanielMSchmidt DanielMSchmidt mentioned this issue Aug 9, 2021
8 tasks
@DanielMSchmidt DanielMSchmidt added the needs-priority Issue has not yet been prioritized; this will prompt team review label Dec 6, 2021
@DanielMSchmidt DanielMSchmidt added priority/important-soon High priority, to be worked on as part of our current release or the following one. and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Feb 10, 2022
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working cdktf feature/tokens priority/important-soon High priority, to be worked on as part of our current release or the following one.
Projects
None yet
2 participants