Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract module address parsing logic #877

Closed
Tracked by #599
radeksimko opened this issue Apr 14, 2022 · 2 comments
Closed
Tracked by #599

Extract module address parsing logic #877

radeksimko opened this issue Apr 14, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request technical-debt

Comments

@radeksimko
Copy link
Member

Background

We have https://github.com/hashicorp/terraform-registry-address which handles parsing and internal representation of the parsed provider addresses in this codebase and terraform-schema.

We need to also parse and represent module addresses in increasingly more places:

Proposal

Look into Terraform Core's codebase and try to extract the logic which is responsible for parsing the module source from there into https://github.com/hashicorp/terraform-registry-address - presumably as ParseModuleSourceString or similar.


Related: hashicorp/terraform#28338

@dbanck
Copy link
Member

dbanck commented Apr 25, 2022

Closed via hashicorp/terraform-registry-address#7 and #891

@dbanck dbanck closed this as completed Apr 25, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request technical-debt
Projects
None yet
Development

No branches or pull requests

2 participants