Add DocsLink for remote module source attributes #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-docslink-for-module-source
branch
2 times, most recently
from
982c114 to
f3db2dd
Compare
radeksimko
suggested changes
Apr 14, 2022
This was referenced Apr 14, 2022
dbanck
force-pushed
the
f-docslink-for-module-source
branch
from
af1666c to
78d165d
Compare
dbanck
force-pushed
the
f-docslink-for-module-source
branch
from
78d165d to
afaf506
Compare
radeksimko
reviewed
Apr 25, 2022
radeksimko
approved these changes
Apr 25, 2022
| @@ -382,6 +382,34 @@ func TestSchemaForDependentModuleBlock_DocsLink(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
| "remote module on unknown registry", | |||
There was a problem hiding this comment.
Thanks for the extra test! 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for hashicorp/vscode-terraform#673
Depends on
This PR adds a
DocsLinkto the depended module schema if the module is a registry (e.g. registry.terraform.io) one.I added a
Versionfield toModuleCall, required for building the docs link. To populate this field a change interraform-lsis required (hashicorp/terraform-ls#874).terraform-schema/module/meta.go
Lines 70 to 75 in af1666c