Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/formatting: log terraform fmt execution time #1034

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

radeksimko
Copy link
Member

From past experience this is a common source of bug reports, for various reasons - often due to tfutils/tfenv#196 which was now resolved, but it seems reasonable to me to log the execution time as it's a commonly used feature, so it's effectively a hot path.

This allows us to rule out TF CLI as a cause, if/when people report performance related issues.

@radeksimko radeksimko added the enhancement New feature or request label Aug 11, 2022
@radeksimko radeksimko self-assigned this Aug 11, 2022
@radeksimko radeksimko requested a review from a team as a code owner August 11, 2022 07:54
@radeksimko radeksimko force-pushed the f-log-tf-fmt branch 2 times, most recently from 8db5b83 to 8f4a50c Compare August 11, 2022 08:09
@radeksimko radeksimko merged commit 7c476e2 into main Aug 11, 2022
@radeksimko radeksimko deleted the f-log-tf-fmt branch August 11, 2022 12:36
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants