textDocument/formatting: log terraform fmt execution time #1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From past experience this is a common source of bug reports, for various reasons - often due to tfutils/tfenv#196 which was now resolved, but it seems reasonable to me to log the execution time as it's a commonly used feature, so it's effectively a hot path.
This allows us to rule out TF CLI as a cause, if/when people report performance related issues.